Incorrect use of CacheResolver in twisted.names.client.createResolver
Open
Nobody has claimed this yet.
bug
names
new
priority-normal
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
BobNovas reported |
|---|---|
| Trac ID | trac#6895 |
| Type | defect |
| Created | 2014-01-09 15:32:12Z |
twisted.names.client.createResolver() includes a cache.CacheResolver in the ResolverChain it returns.
As far as I can tell, the CacheResolver's cache is never loaded.
Including CacheResolver in the returned ResolverChain simply causes an extra trip through ResolverChain._lookup() -- the CacheResolver _lookup always fails.
Searchable metadata
trac-id__6895 6895
type__defect defect
reporter__BobNovas BobNovas
priority__normal normal
milestone__
branch__
branch_author__
status__new new
resolution__None None
component__names names
keywords__
time__1389281532000000 1389281532000000
changetime__1389281532000000 1389281532000000
version__None None
owner__
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at twisted.names.client.createResolver and trace how its ResolverChain uses CacheResolver. Read ResolverChain._lookup to verify whether the cache is loaded or whether the lookup always fails; done means the returned resolver chain no longer performs an unnecessary failing cache lookup, with behavior covered by relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100