Use ReactorBuilder for the IPv4 UDP tests
Open
Nobody has claimed this yet.
core
enhancement
new
priority-low
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
@habnabit reported |
|---|---|
| Trac ID | trac#6828 |
| Type | enhancement |
| Created | 2013-11-12 16:15:38Z |
As described in [#5086#comment:41 this comment] on #5069, the old IPv4 UDP tests and the new IPv6 UDP tests now live in different places, with the former not using ReactorBuilder. These tests should be moved from twisted.test.test_udp into twisted.internet.test.test_udp.DatagramTransportTestsMixin.
Searchable metadata
trac-id__6828 6828
type__enhancement enhancement
reporter__habnabit habnabit
priority__low low
milestone__
branch__
branch_author__
status__new new
resolution__None None
component__core core
keywords__
time__1384272938000000 1384272938000000
changetime__1385939598000000 1385939598000000
version__None None
owner__
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the IPv4 UDP tests in twisted.test.test_udp with the IPv6 tests and DatagramTransportTestsMixin in twisted.internet.test.test_udp. Move the IPv4 tests into the mixin and use ReactorBuilder consistently, then run the UDP test suite to verify the tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100