twisted / twisted/twisted

twisted.web.http.Request.setETag is incompletely (and mostly indirectly) tested

Open
#6,128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug new priority-normal web
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

exarkun's avatar @exarkun reported
Trac ID trac#6128
Type defect
Created 2012-10-16 13:29:29Z

test_http.py doesn't test any part of this method. Some other part of twisted.web.test does exercise much of it, but misses a few of the cases it handles (found while porting http.py to Python 3).

Searchable metadata
trac-id__6128 6128
type__defect defect
reporter__exarkun exarkun
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__web web
keywords__ 
time__1350394169000000 1350394169000000
changetime__1350394169000000 1350394169000000
version__None None
owner__ 
cc__jknight

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in test_http.py and inspect Request.setETag alongside the existing twisted.web tests that exercise it indirectly. Add direct coverage for the cases currently missed, then run the relevant HTTP tests and confirm the method's handled cases are covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.