twisted / twisted/twisted

twisted.trial.unittest.TestCase's usage of the reactor should be parameterized

Open
#6,047 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new priority-normal trial
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

itamarst's avatar @itamarst reported
Trac ID trac#6047
Type enhancement
Created 2012-10-04 13:07:01Z

Currently the reactor used by trial's TestCase is the global one; it would be good to allow some way to hook in a custom reactor instance.

Searchable metadata
trac-id__6047 6047
type__enhancement enhancement
reporter__itamar itamar
priority__normal normal
milestone__ 
branch__ 
branch_author__itamarst itamarst
status__new new
resolution__None None
component__trial trial
keywords__ 
time__1349356021000000 1349356021000000
changetime__1349360454000000 1349360454000000
version__None None
owner__ 
cc__jml

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with twisted.trial.unittest.TestCase and trace where it obtains and uses the global reactor. Determine how a custom reactor instance should be supplied and how existing behavior remains compatible. Done means TestCase can use a caller-provided reactor rather than only the global one, with relevant trial tests covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.