Deprecate inet_pton, inet_ntop, and adict in twisted.python.compat

	@itamarst reported
Trac ID	trac#5895
Type	task
Created	2012-08-21 12:33:38Z
Branch	https://github.com/twisted/twisted/tree/inet-compat-5895

inet_pton, inet_ntop, and adict in twisted.python.compat are no longer necessary (2.6 has good implementations of first two, third is just junk). They should be deprecated.

Attachments:

• ticket5895.patch (10273 bytes) - added by mateusbraga on 2013-04-15 03:28:14Z - Patch to solve this ticket.
• ticket5895_2.patch (10754 bytes) - added by mateusbraga on 2013-04-16 01:45:03Z - twisted/topfiles/5895.removal added to the patch
• ticket5895_3.patch (10907 bytes) - added by mateusbraga on 2013-04-27 04:23:27Z - Included some of thijs suggestions
• ticket5895_4.patch (11665 bytes) - added by mateusbraga on 2013-04-28 00:06:55Z - Included thijs suggestions
• ticket5895_5.patch (506 bytes) - added by mateusbraga on 2013-05-16 01:46:25Z - Patch to pass test

trac-id__5895 5895
type__task task
reporter__itamar itamar
priority__normal normal
milestone__De_Python_2ify De-Python-2ify
branch__branches_inet_compat_5895 branches/inet-compat-5895
branch_author__mateusbraga mateusbraga
status__new new
resolution__None None
component__core core
keywords__ 
time__1345552418000000 1345552418000000
changetime__1595670454676254 1595670454676254
version__None None
owner__ 
cc__thijs

Start by inspecting twisted.python.compat and the attached ticket5895 patches, including the later versions and the added twisted/topfiles/5895.removal file. Review the existing test changes in those patches and confirm that inet_pton, inet_ntop, and adict are deprecated as intended without breaking compatibility. Done means the relevant tests pass and the removal metadata is consistent.