twisted.test.test_strcred.TestSSHChecker.test_isChecker() fails with Twisted Conch not available

	Arfrever reported
Trac ID	trac#5703
Type	defect
Created	2012-06-06 02:48:41Z

twisted.test.test_strcred.TestSSHChecker.test_isChecker() has been introduced in Twisted 12.1.0 and fails.

twisted.test.test_strcred
  TestAnonymousChecker
    testAnonymousAccessSucceeds ...                                        [OK]
    test_isChecker ...                                                     [OK]
  TestCheckerOptions
    test_createsDictionary ...                                             [OK]
    test_createsList ...                                                   [OK]
    test_credInterfacesProvidesLists ...                                   [OK]
    test_displaysHelpCorrectly ...                                         [OK]
    test_displaysListCorrectly ...                                         [OK]
    test_invalidAuthError ...                                              [OK]
    test_listDoesNotDisplayDuplicates ...                                  [OK]
    test_unexpectedException ...                                           [OK]
  TestFileDBChecker
    test_failsWithEmptyFilename ...                                        [OK]
    test_fileCheckerFailsPassword ...                                      [OK]
    test_fileCheckerFailsUsername ...                                      [OK]
    test_fileCheckerSucceeds ...                                           [OK]
    test_isChecker ...                                                     [OK]
    test_warnWithBadFilename ...                                           [OK]
  TestLimitingInterfaces
    test_canAddSupportedChecker ...                                        [OK]
    test_failOnAddingUnsupportedChecker ...                                [OK]
    test_helpAuthLimitsOutput ...                                          [OK]
    test_helpAuthTypeLimitsOutput ...                                      [OK]
    test_supportsAllInterfaces ...                                         [OK]
    test_supportsCheckerFactory ...                                        [OK]
    test_supportsInterface ...                                             [OK]
    test_unsupportedInterfaceError ...                                     [OK]
  TestMemoryChecker
    test_badFormatArgString ...                                            [OK]
    test_isChecker ...                                                     [OK]
    test_memoryCheckerFailsPassword ...                                    [OK]
    test_memoryCheckerFailsUsername ...                                    [OK]
    test_memoryCheckerSucceeds ...                                         [OK]
  TestPublicAPI
    test_emptyDescription ...                                              [OK]
    test_invalidAuthType ...                                               [OK]
  TestSSHChecker
    test_isChecker ...                                                  [ERROR]
  TestStrcredFunctions
    test_findCheckerFactories ...                                          [OK]
    test_findCheckerFactory ...                                            [OK]
  TestUnixChecker
    test_isChecker ...                                                     [OK]
    test_unixCheckerFailsPassword ...                                      [OK]
    test_unixCheckerFailsUsername ...                                      [OK]
    test_unixCheckerSucceeds ...                                           [OK]

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/twisted-12.1.0-r1000/temp/tests-2.7/usr/lib64/python2.7/site-packages/twisted/test/test_strcred.py", line 361, in test_isChecker
    sshChecker = strcred.makeChecker('sshkey')
  File "/var/tmp/portage/dev-python/twisted-12.1.0-r1000/temp/tests-2.7/usr/lib64/python2.7/site-packages/twisted/cred/strcred.py", line 127, in makeChecker
    return findCheckerFactory(authType).generateChecker(argstring)
  File "/var/tmp/portage/dev-python/twisted-12.1.0-r1000/temp/tests-2.7/usr/lib64/python2.7/site-packages/twisted/cred/strcred.py", line 112, in findCheckerFactory
    raise InvalidAuthType(authType)
twisted.cred.strcred.InvalidAuthType: sshkey

twisted.test.test_strcred.TestSSHChecker.test_isChecker
-------------------------------------------------------------------------------
Ran 38 tests in 0.412s

FAILED (errors=1, successes=37)

Attachments:

• twisted-12.1.0-remove-tests-conch-dependency.patch (459 bytes) - added by marienz on 2012-06-10 10:17:55Z - skip a test if conch is not available

trac-id__5703 5703
type__defect defect
reporter__Arfrever Arfrever
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__ 
time__1338950921000000 1338950921000000
changetime__1384261162000000 1384261162000000
version__None None
owner__ 
cc__Arfrever cc__marienz cc__hynek

Start with twisted.test.test_strcred.TestSSHChecker.test_isChecker and the traceback showing strcred.makeChecker('sshkey') fails when Conch is unavailable. Review the attached twisted-12.1.0-remove-tests-conch-dependency.patch and verify that the test is skipped or guarded without Conch while the remaining strcred tests still pass.