Reactor builder tests should have a better heuristic for when to skip
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
@glyph reported |
|---|---|
| Trac ID | trac#5216 |
| Type | enhancement |
| Created | 2011-08-03 02:37:38Z |
As happened with #5088, an error which causes the reactor under test to raise an ImportError will cause all the tests for that reactor to be skipped.
The reactor builder utilities should allow specifying a proxy module as the "should I test this" module. For example, win32eventreactor should always have its tests run if the suite can import win32all.
Searchable metadata
trac-id__5216 5216
type__enhancement enhancement
reporter__glyph glyph
priority__normal normal
milestone__
branch__
branch_author__
status__new new
resolution__None None
component__core core
keywords__
time__1312339058000000 1312339058000000
changetime__1312339058000000 1312339058000000
version__None None
owner__
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the reactor builder test utilities and review their existing skip heuristic, especially how ImportError is handled. Compare the win32eventreactor/win32all case and the behavior described in #5088. Done means a proxy-module option determines whether a reactor suite is skipped without hiding ImportError failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100