twisted / twisted/twisted

The fix for nondeterminism in WebClientSSLTestCase.tearDown should be cleaner

Open
#5,185 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core enhancement new priority-normal
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

itamarst's avatar @itamarst reported
Trac ID trac#5185
Type enhancement
Created 2011-07-07 13:37:54Z

WebClientSSLTestCase.tearDown delays ending the test for a bit, so TCP disconnection has time to happen, and we don't get dirty reactor failures. JP believes it's possible to do this more cleanly.

Searchable metadata
trac-id__5185 5185
type__enhancement enhancement
reporter__itamar itamar
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__ 
time__1310045874000000 1310045874000000
changetime__1310071092000000 1310071092000000
version__None None
owner__ 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating WebClientSSLTestCase.tearDown and understanding why it delays test completion. The work is done when TCP disconnection no longer needs an arbitrary delay and the dirty reactor failures are avoided through a cleaner cleanup approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.