twisted.web._flatten._writeFlattenedData needs an errback.
Open
Nobody has claimed this yet.
enhancement
new
priority-normal
web
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
amberite reported |
|---|---|
| Trac ID | trac#5133 |
| Type | enhancement |
| Created | 2011-06-02 18:36:52Z |
Excerpted from the #twisted.web IRC channel:
exarkun: So _writeFlattenedData calls request.write and that raises an exception
exarkun: And there's no handler for it, because the write is done in cby (the heck?) which has no errbacks after it
exarkun: So it's an unhandled error
Searchable metadata
trac-id__5133 5133
type__enhancement enhancement
reporter__amberite amberite
priority__normal normal
milestone__
branch__
branch_author__
status__new new
resolution__None None
component__web web
keywords__
time__1307039812000000 1307039812000000
changetime__1307059021000000 1307059021000000
version__None None
owner__
cc__jknight
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing twisted.web._flatten._writeFlattenedData, especially the cby callback around request.write. Check how exceptions from request.write are currently propagated and how errbacks are attached. Done means the resulting error is handled through an errback rather than remaining unhandled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100