twisted.web.proxy.ReverseProxyResource does not support anything like ProxyPreserveHost
Open
Nobody has claimed this yet.
enhancement
new
priority-normal
web
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
 |
@mwhudson reported |
|---|---|
| Trac ID | trac#4917 |
| Type | enhancement |
| Created | 2011-02-28 01:39:04Z |
I'm not completely sure of the theory here, but in practice its convenient to use ProxyPreserveHost in one's apache config (e.g. when proxying to jenkins it seems to be required as I can't find any other way to tell jenkins what its hostname is).
This would be a few lines change in the code of ReverseProxyResource.
Searchable metadata
trac-id__4917 4917
type__enhancement enhancement
reporter__mwh mwh
priority__normal normal
milestone__
branch__
branch_author__
status__new new
resolution__None None
component__web web
keywords__
time__1298857144000000 1298857144000000
changetime__1298864220000000 1298864220000000
version__None None
owner__mwh mwh
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ReverseProxyResource entry point and reading how it constructs proxied requests. Determine how a ProxyPreserveHost-like option should affect the forwarded host, then verify the behavior with the existing proxy tests if present; done means callers can preserve the original host when configuring the resource.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100