twisted / twisted/twisted

twisted.web server doesn't process requests with LF-delimited headers

Open
#4,893 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug new priority-normal web
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

ivank's avatar ivank reported
Trac ID trac#4893
Type defect
Created 2011-02-18 00:03:04Z

The popular web servers out there (Apache, nginx) support requests that contain headers delimited by bare LF newlines (vs. the correct CRLF). Thus, there must be at least a few broken clients in the wild. I would prefer to support these broken clients.

The fix will probably look similar to #3833

Searchable metadata
trac-id__4893 4893
type__defect defect
reporter__ivank ivank
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__web web
keywords__ 
time__1297987384000000 1297987384000000
changetime__1298066227000000 1298066227000000
version__None None
owner__ 
cc__jknight cc__ivank

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the twisted.web server request-parsing entry point and review the approach described in issue #3833. Confirm how headers are currently split and define done as accepting requests whose headers use bare LF delimiters, with regression coverage for that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.