twisted.conch.telnet doesn't call enableRemote when using python -O

	ivank reported
Trac ID	trac#4349
Type	defect
Created	2010-03-05 15:58:57Z

twisted.conch.telnet has an assert which should probably not be an assert:

assert self.enableRemote(option), "enableRemote must return True in this context (for option %r)" % (option,)

(after all, enableRemote might actually mutate something, and in this case, it looks like it does.)

python -O `which trial` twisted.conch.test.test_telnet

...

===============================================================================
[FAIL]: twisted.conch.test.test_telnet.TelnetTransportTestCase.testAcceptedEnableRequest

Traceback (most recent call last):
  File "/home/a/Projects/Twisted/twisted/conch/test/test_telnet.py", line 400, in <lambda>
    d.addCallback(lambda _:  self._enabledHelper(h, eR=['\x42']))
  File "/home/a/Projects/Twisted/twisted/conch/test/test_telnet.py", line 231, in _enabledHelper
    self.assertEquals(o.enabledRemote, eR)
twisted.trial.unittest.FailTest: not equal:
a = []
b = ['B']

===============================================================================
[FAIL]: twisted.conch.test.test_telnet.TelnetTransportTestCase.testNegotiationBlocksFurtherNegotiation

Traceback (most recent call last):
  File "/home/a/Projects/Twisted/twisted/conch/test/test_telnet.py", line 464, in <lambda>
    dR=['\x24']))
  File "/home/a/Projects/Twisted/twisted/conch/test/test_telnet.py", line 231, in _enabledHelper
    self.assertEquals(o.enabledRemote, eR)
twisted.trial.unittest.FailTest: not equal:
a = []
b = ['$']

Attachments:

• 4349.patch (656 bytes) - added by MostAwesomeDude on 2011-03-23 05:17:09Z - Trivial fix

trac-id__4349 4349
type__defect defect
reporter__ivank ivank
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__conch conch
keywords__ 
time__1267804737000000 1267804737000000
changetime__1301352949000000 1301352949000000
version__None None
owner__MostAwesomeDude MostAwesomeDude

Start in twisted.conch.telnet at the assert around enableRemote, then run python -O which trial twisted.conch.test.test_telnet as reported. Use twisted/conch/test/test_telnet.py, especially testAcceptedEnableRequest and testNegotiationBlocksFurtherNegotiation, to verify that remote options are enabled and the tests pass with optimization enabled.