twisted / twisted/twisted

LoopingCall lacks reactor argument

Open
#4,276 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug core new priority-normal
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

teamnoir's avatar teamnoir reported
Trac ID trac#4276
Type defect
Created 2010-02-15 18:45:40Z

The doc for twisted.internet.task.LoopingCall is ambiguous. It's not clear whether it intends to document a "clock" argument to __init__ or whether it intends to document an instance variable. In any case, there should be a way to pass my reactor to LoopingCall as part of the initialization, without forcing the global reactor to be initialized.

Fixing this looks like it will require changing the calling convention of LoopingCall, (which might be why it hasn't been done already), so I haven't included a patch.

Searchable metadata
trac-id__4276 4276
type__defect defect
reporter__teamnoir teamnoir
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__ 
time__1266259540000000 1266259540000000
changetime__1266370337000000 1266370337000000
version__None None
owner__ 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the documentation and init API for twisted.internet.task.LoopingCall, then trace how it obtains the reactor and check the existing calling convention. Done means the intended clock or reactor argument is unambiguous and can be supplied during initialization without forcing the global reactor to initialize.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.