twisted / twisted/twisted

Words IRC Server does not implement AWAY

Open
#3,668 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new priority-low words
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

tenth10th's avatar @tenth10th reported
Trac ID trac#3668
Type enhancement
Created 2009-02-23 00:43:58Z
Branch https://github.com/twisted/twisted/tree/irc-away-3668

Here's the traceback you get when Pidgin attempts to log into a Words server:

2009-02-22 19:26:06-0500 [IRCUser,0,127.0.0.1] Unhandled Error
	Traceback (most recent call last):
	  File "/home/glyph/Projects/Twisted/trunk/twisted/python/context.py", line 37, in callWithContext
	    return func(*args,**kw)
	  File "/home/glyph/Projects/Twisted/trunk/twisted/internet/selectreactor.py", line 146, in _doReadOrWrite
	    why = getattr(selectable, method)()
	  File "/home/glyph/Projects/Twisted/trunk/twisted/internet/tcp.py", line 459, in doRead
	    return self.protocol.dataReceived(data)
	  File "/home/glyph/Projects/Twisted/trunk/twisted/words/protocols/irc.py", line 172, in dataReceived
	    self.handleCommand(command, prefix, params)
	--- <exception caught here> ---
	  File "/home/glyph/Projects/Twisted/trunk/twisted/words/protocols/irc.py", line 184, in handleCommand
	    self.irc_unknown(prefix, command, params)
	  File "/home/glyph/Projects/Twisted/trunk/twisted/words/protocols/irc.py", line 191, in irc_unknown
	    raise NotImplementedError(command, prefix, params)
	exceptions.NotImplementedError: ('AWAY', '', [])

Attachments:

  • ircAway.patch (8747 bytes) - added by elitak on 2009-09-19 00:20:31Z - svn patch on main branch
  • ircAway-2.patch (10485 bytes) - added by elitak on 2009-09-21 18:35:09Z - Here's the new patch
Searchable metadata
trac-id__3668 3668
type__enhancement enhancement
reporter__tenth tenth
priority__low low
milestone__ 
branch__branches_irc_away_3668 branches/irc-away-3668
branch_author__therve therve
status__new new
resolution__None None
component__words words
keywords__ 
time__1235349838000000 1235349838000000
changetime__1268269295000000 1268269295000000
version__None None
owner__elitak elitak
cc__jesstess

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AWAY traceback in twisted/words/protocols/irc.py and review the attached ircAway.patch and ircAway-2.patch. Trace how IRC commands are dispatched, then verify that Words handles AWAY without raising NotImplementedError when a client such as Pidgin connects.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.