twisted / twisted/twisted

twisted.web.proxy doesn't forward all received headers

Open
#3,250 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug new priority-normal web
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

exarkun's avatar @exarkun reported
Trac ID trac#3250
Type defect
Created 2008-05-28 20:49:19Z

twisted.web.proxy uses request.getAllHeaders() (in three places, it seems) to find the headers to pass on with the outgoing request it makes. However, since this only includes the final value received for any particular header, it doesn't completely proxy the request.

After #7478 is resolved, there will be a way to get all header values and twisted.web.proxy can forward them all on.

Searchable metadata
trac-id__3250 3250
type__defect defect
reporter__exarkun exarkun
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__web web
keywords__ 
time__1212007759000000 1212007759000000
changetime__1212007759000000 1212007759000000
version__None None
owner__ 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in twisted.web.proxy by reviewing the three uses of request.getAllHeaders() described in the issue, then check the resolution of #7478 for the way to access all header values. Done means the proxy forwards every received header value in its outgoing request rather than only the final value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.