twisted / twisted/twisted

Logging should deal nicely with problems logging Failures

Open
#2,834 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug core logging new priority-normal
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

itamarst's avatar @itamarst reported
Trac ID trac#2834
Type defect
Created 2007-09-20 14:17:45Z

If Failure.getTraceback blows up, nothing useful will get logged (and logging stops, but that's another ticket.)

To reproduce just log a failure whose getTraceback method has been overridden to raise exception; it happens in wild too! E.g. I've seen this happen when max recursion limit is exceeded in Deferred callbacks.

Searchable metadata
trac-id__2834 2834
type__defect defect
reporter__itamarst itamarst
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__logging logging
time__1190297865000000 1190297865000000
changetime__1429207554268136 1429207554268136
version__None None
owner__ 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a Failure whose getTraceback method raises an exception, then trace the logging path that handles the Failure. Done means the logging path still produces useful output when getTraceback fails, rather than producing nothing; the issue notes that stopping logging is a separate ticket.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.