twisted / twisted/twisted

trial reporter plugins can't get real failures unless they subclass trial's reporter class

Open
#2,784 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug new priority-normal trial
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

exarkun's avatar @exarkun reported
Trac ID trac#2784
Type defect
Created 2007-08-14 20:23:34Z

These lines from trial's TestCase.run are problematic:

        if not isinstance(result, reporter.TestResult):
            result = PyUnitResultAdapter(result)
Searchable metadata
trac-id__2784 2784
type__defect defect
reporter__exarkun exarkun
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__trial trial
keywords__ 
time__1187123014000000 1187123014000000
changetime__1187123014000000 1187123014000000
version__None None
owner__ 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Trial's TestCase.run and inspect the handling of reporter.TestResult and PyUnitResultAdapter. Trace how reporter plugins receive results, then identify the expected behavior for plugins that do not subclass Trial's reporter class and verify it with the relevant Trial tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.