Handling of EINTR in threadedselectreactor.py

	dkosovic reported
Trac ID	trac#2354
Type	defect
Created	2007-01-04 12:54:47Z

The select loop in twisted/internet/threadedselectreactor.py (or _threadedselect.py in SVN trunk) which handles EINTR returns immediately rather than retrying again with a continue statement e.g like the continue in the attached patch.

For me on Fedora Core 6 with wxPython, _doSelectInThread only occasionally does one successful iteration because of EINTR return statement.

Attachments:

• twisted-EINTR.patch (485 bytes) - added by dkosovic on 2007-01-04 12:55:34Z -

trac-id__2354 2354
type__defect defect
reporter__dkosovic dkosovic
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__ 
time__1167915287000000 1167915287000000
changetime__1178610478000000 1178610478000000
version__None None
owner__dkosovic dkosovic

Start in twisted/internet/threadedselectreactor.py and inspect the select loop used by _doSelectInThread, comparing its EINTR handling with the attached twisted-EINTR.patch. Confirm that an EINTR result retries the loop rather than returning immediately; done means the threaded reactor continues operating after an interrupted select call.