twisted / twisted/twisted

Todo attribute checking

Open
#2,243 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement new priority-normal trial
Dominant language
Python
Stars
6k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
10

Description

mithrandi's avatar @mithrandi reported
Trac ID trac#2243
Type enhancement
Created 2006-11-21 14:57:55Z

Setting a todo attribute on a test method or TestCase or somesuch to anything other than a str instance (for example, a unicode instance) results in trial silently ignoring the attribute. It would be nice if it emitted a warning or raised an exception or otherwise complained about it.

Searchable metadata
trac-id__2243 2243
type__enhancement enhancement
reporter__mithrandi mithrandi
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__trial trial
keywords__ 
time__1164121075000000 1164121075000000
changetime__1164121075000000 1164121075000000
version__None None
owner__ 
cc__mithrandi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Twisted's trial implementation by locating how todo attributes are read from test methods and TestCase instances. Reproduce the case with a non-str value such as unicode, then add coverage and ensure trial warns or raises instead of silently ignoring the invalid attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.