No-op timer service in _twistw.py is (probably) unnecessary

	soyt reported
Trac ID	trac#1764
Type	enhancement
Created	2006-05-30 10:19:39Z

I have raised that point on the mailing-list some time ago, but I think it deserves a ticket, for the record.

tw.scripts._twistw.runApp adds a no-op timer service to the application, to pretend that the select reactor can be interrupted by Ctrl-C.
But tw.internet.selectreactor already wraps the select call to circumvent this win32 malfunction, among others.

So the extra service is unnecessary. Furthermore, it is added
unconditionally, even if the installed reactor does not actually
need it (I don't know much about IOCP, but maybe it does not). It might not have a huge performance impact, but correctness does not hurt I guess.

Attachments:

• remove-twistd-time-service.patch (14591 bytes) - added by zseil on 2008-11-02 15:35:10Z - patch, v2

trac-id__1764 1764
type__enhancement enhancement
reporter__soyt soyt
priority__low low
milestone__ 
branch__ 
branch_author__ 
status__new new
resolution__None None
component__core core
keywords__win32_twistd win32 twistd
time__1148984379000000 1148984379000000
changetime__1279124644000000 1279124644000000
version__None None
owner__zseil zseil
cc__teratorn cc__zseil

Start with tw.scripts._twistw.runApp and the no-op timer service, then read tw.internet.selectreactor to understand the existing select-call workaround. Review the attached remove-twistd-time-service.patch and verify whether the service can be removed without affecting Ctrl-C behavior or reactors that may need it.