investigate ZipArchive.archive LSP violation
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 10
Description
Hmmmmmm. Ignore overrides typically mean a breakage of LSP. Is that happening here? I think the idea is that we want to conform to a more abstract FilePath protocol (which isn't specified because [`IFilePath` can't be generic](https://github.com/Shoobx/mypy-zope/issues/95) and `ZipArchive` and `ZipPath` are actually derivatives of that as-yet-unspecified thing?
If I'm interpreting this correctly can you file a separate issue, and maybe drop a comment on this line
Originally posted by @glyph in https://github.com/twisted/twisted/pull/11943#discussion_r1313332562
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the ZipArchive and ZipPath implementations and the referenced discussion in pull request #11943. Determine whether their ignore overrides violate the intended abstract FilePath protocol and document the conclusion; completion should establish whether a separate change is needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100