twisted / twisted/klein

Field uses deprecated attr.ib(cmp=False)

Open
#408 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
838
Forks
123
Avg merge
7h 58m
Merged PRs (30d)
12

Description

https://github.com/twisted/klein/blob/4dbd5f304fcdba516ee4dcebf003cf05b630ddb9/src/klein/_form.py#L98

This causes attrs to issue a deprecation warning:

builtins.DeprecationWarning: The usage of cmp is deprecated and will be removed on or after 2021-06-01. Please use eq and order instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/klein/_form.py line 98, where the field uses the deprecated cmp argument. Check the attrs warning and the surrounding field definition, then update the deprecated usage to the supported eq/order options and verify that the deprecation warning is gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.