Unwanted logs
Open
Nobody has claimed this yet.
feature
- Dominant language
- Python
- Stars
- 838
- Forks
- 123
- Avg merge
- 7h 58m
- Merged PRs (30d)
- 12
Description
I am not using twisted logs infrastructure.
Also, I am using a json formatter and not a concat formatter.
In Klein run method there is this block of code:
if logFile is None:
logFile = sys.stdout
log.startLogging(logFile)
What happens is that I get each log twice in my stdout, once with a concat formatter.
I would like an option to tell Klein not to startLogging at all.
Thanks ahead for any help :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Klein's run method and the block that assigns sys.stdout and calls log.startLogging. Trace how logging is configured when logFile is omitted, then add an option that prevents Klein from starting Twisted logging. Done means callers can keep their existing JSON formatter without duplicate output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100