Use KleinResource, or a subset thereof, in the error handling pipeline
Open
Nobody has claimed this yet.
improvement
- Dominant language
- Python
- Stars
- 838
- Forks
- 123
- Avg merge
- 7h 58m
- Merged PRs (30d)
- 12
Description
In https://github.com/twisted/klein/pull/139#pullrequestreview-15010666, glyph noted that it may be preferable to reuse code from KleinResource, possible the entire class when handling errors so that we have full consistency in how return values from methods decorated with handle_errors and route are rendered.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read KleinResource first, then trace the existing error-handling path and the methods decorated with handle_errors and route. Compare how return values are rendered in each path; done means error handling uses KleinResource or an appropriate subset for consistent rendering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100