Run klein in non-main thread
Open
Nobody has claimed this yet.
improvement
- Dominant language
- Python
- Stars
- 838
- Forks
- 123
- Avg merge
- 7h 58m
- Merged PRs (30d)
- 12
Description
One problem is that Klein.run() can't pass 'installSignalHandlers' to reactor.run() thus reactor will complain like exceptions.ValueError: signal only works in main thread.
Can we add parameter to keep reactor quiet when run klein in a non-main thread?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Klein.run() and trace the call to reactor.run(), focusing on how run options are currently passed. Add support for the installSignalHandlers parameter so callers can disable signal handling in non-main threads, then verify that Klein.run() forwards the setting to reactor.run().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100