twbs / twbs/bootstrap-rubygem

Lots of errors after upgrading dartsass-sprockets to v3.1.0

Open
#291 2 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
2k
Forks
437
Avg merge
1h
Merged PRs (30d)
1

Description

After performing a bundle update on my Rails 7.1 project, the site is broken because the bootstrap gem uses @import heavily which is now deprecated. For example:

Deprecation Warning on line 1, column 9 of ../../../../bootstrap-5.3.3/assets/stylesheets/_bootstrap.scss: 
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import
  ╷
1 │ @import "bootstrap/mixins/banner";
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
Deprecation Warning on line 7, column 9 of ../../../../bootstrap-5.3.3/assets/stylesheets/_bootstrap.scss: 
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import
  ╷
7 │ @import "bootstrap/functions";
  │         ^^^^^^^^^^^^^^^^^^^^^
  ╵
Deprecation Warning on line 8, column 9 of ../../../../bootstrap-5.3.3/assets/stylesheets/_bootstrap.scss: 
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import
  ╷
8 │ @import "bootstrap/variables";
  │         ^^^^^^^^^^^^^^^^^^^^^
  ╵
Deprecation Warning on line 9, column 9 of ../../../../bootstrap-5.3.3/assets/stylesheets/_bootstrap.scss: 
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import
  ╷
9 │ @import "bootstrap/variables-dark";
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
Deprecation Warning on line 10, column 9 of ../../../../bootstrap-5.3.3/assets/stylesheets/_bootstrap.scss: 
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import
   ╷
10 │ @import "bootstrap/maps";
   │         ^^^^^^^^^^^^^^^^
   ╵

Is there a version for SASS after version 3.0 planned that will help?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Rails 7.1 failure after upgrading dartsass-sprockets to v3.1.0, then inspect bootstrap-5.3.3/assets/stylesheets/_bootstrap.scss and its reported @import warnings. Determine the project’s intended compatibility path for Dart Sass 3.0; done should mean the Bootstrap gem no longer leaves this upgrade blocked by the reported Sass deprecations.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, scss
Domain
build-system, frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.