twbs / twbs/bootstrap-rubygem

4.3.0 jQuery is not defined

Open
#173 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
2k
Forks
437
Avg merge
1h
Merged PRs (30d)
1

Description

Upgrading from 4.2.0 to 4.3.0 breaks my test suite.

Tests that pass on 4.2.0 now fail, all of the issues seem to be caused by Javascript not loading properly on the page (Ajax calls breaking, etc.)

5) My spec
     Got 0 failures and 2 other errors:

     5.1) Failure/Error: page.evaluate_script('jQuery.active').zero?

          Selenium::WebDriver::Error::JavascriptError:
            javascript error: jQuery is not defined
              (Session info: headless chrome=73.0.3683.103)
              (Driver info: chromedriver=73.0.3683.20 (8e2b610813e167eee3619ac4ce6e42e3ec622017),platform=Mac OS X 10.14.4 x86_64)

          [Screenshot]: tmp/screenshots/....png

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing spec and its page.evaluate_script('jQuery.active') check, then compare how JavaScript assets load in versions 4.2.0 and 4.3.0. Trace the page setup around the failing Ajax calls; done means jQuery is available in the page and the previously passing test suite runs successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery, ruby
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.