bug: crash on new shell after a long, long session
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 38
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
from webexec.err:
[Fx] RUNNING
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x28 pc=0x1054c8b44]
goroutine 8729368 [running]:
github.com/tuzig/webexec/peers.(*Pane).OnMessage(0x14002005600, {0x68?, {0x140036b205c?, 0x105014084?, 0x1056b8801?}})
/Users/daonb/src/webexec/peers/pane.go:278 +0x34
main.handleAddPane.func1.1({0xf8?, {0x140036b205c?, 0x0?, 0x140045b6e70?}})
/Users/daonb/src/webexec/handlers.go:190 +0xb8
github.com/pion/webrtc/v3.(*DataChannel).onMessage(0x140028de000?, {0xa0?, {0x140036b205c?, 0xffff?, 0x140004a17a8?}})
/Users/daonb/go/pkg/mod/github.com/pion/webrtc/v3@v3.2.32/datachannel.go:300 +0x114
github.com/pion/webrtc/v3.(*DataChannel).readLoop(0x14000add440)
/Users/daonb/go/pkg/mod/github.com/pion/webrtc/v3@v3.2.32/datachannel.go:378 +0x5c
created by github.com/pion/webrtc/v3.(*DataChannel).handleOpen in goroutine 8495940
/Users/daonb/go/pkg/mod/github.com/pion/webrtc/v3@v3.2.32/datachannel.go:330 +0x1c4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting peers/pane.go at line 278 and the message handler in handlers.go at line 190, following the panic stack trace. Reproduce the crash after a long session if possible and verify that opening a new shell no longer causes a nil pointer dereference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100