tursodatabase / tursodatabase/libsql
Make sure S3 restoration works with encryption
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 17.2k
- Forks
- 531
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 1
Description
I vaguely remember that there's a path in restoring from S3, where we just apply WAL frames to the main db file to restore it. When the main db file is compressed however, we can't just slap plaintext frames there, we need to make sure they're encrypted. We just need to make sure we go through the same VFS when writing to the main db file.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the S3 restoration path that applies WAL frames to the main database file, then trace how writes currently bypass or use the VFS. Verify the restoration path with a compressed, encrypted main database and confirm that the applied frames are encrypted consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- database, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100