tursodatabase / tursodatabase/libsql
bottomless restored an invalid snapshot without complaints
Open
Nobody has claimed this yet.
bottomless
nemesis
- Dominant language
- C
- Stars
- 17.2k
- Forks
- 531
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 1
Description
This might be hard to reproduce, but here is how we can do it:
- Kill the machine/process while snapshot upload is in progress
- Restore it
- Bottomless does not complain that restoration was not valid
Ideally, I want it to fail and complain
(slightly related to #716)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by investigating the bottomless snapshot upload and restore flow, then reproduce the reported sequence: interrupt a snapshot upload, restore it, and check whether invalid restoration is detected. Done means the invalid restoration produces a complaint rather than completing silently; issue #716 is noted as related.
Written by the indexing model from the issue text.
Assessment
- Domain
- database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100