tursodatabase / tursodatabase/libsql

bottomless does not check if the snapshot is valid before applying

Open
#716 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bottomless nemesis
Dominant language
C
Stars
17.2k
Forks
531
Avg merge
1h 12m
Merged PRs (30d)
1

Description

Bottomless assumes that files on S3 are correct. It is possible that we might have done a partial upload. After downloading the snapshot from S3, it should verify if the contents are correct, may be using checksums

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names only the Bottomless snapshot download and apply flow and S3; no file or test is identified. Start by locating that flow and checking how snapshot integrity is currently represented. Done means a partial or corrupted download is detected before it is applied, with a regression test covering the failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws
Domain
cloud, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.