tursodatabase / tursodatabase/libsql
Expose FromValue for custom types
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 17.2k
- Forks
- 531
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 1
Description
Hi,
I noticed FromValue implements Sealed and isn't re-exposed to external crates. just checking if this is by design or if you would be open to allowing consumers to implement this trait on custom types (i.e. enums, etc.). It would make integration with any code generated sql queries, etc. a lot easier.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the FromValue trait and its Sealed implementation, then read how the public API exposes traits to external crates. Clarify whether custom implementations are intended and what API or compatibility constraints apply; done requires a maintainer-approved decision and corresponding coverage for custom types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- database
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100