tursodatabase / tursodatabase/libsql
CI doesn't catch failing Windows build
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 17.2k
- Forks
- 531
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 1
Description
As described in #2005, the Windows build is failing. This is reproducible with a simple cargo new helloworld on Windows with libsql 0.9.2 added as a dependency.
The relevant workflow is here.
I suspect the reason this is not caught is because PowerShell, the default shell for the windows-latest runner, may be aliasing cp to Copy-Item. It also might be because cp is added to the path from Git Bash or MSYS2. So build.rs succeeds in GitHub Actions, but it won't work on a typical Windows user's system since there will be no cp command.
#2005, #1657, #1969 related
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/rust.yml at lines 222-244 and reproduce the reported cargo new helloworld case on Windows with libsql 0.9.2. Inspect the workflow shell and the build.rs behavior, then verify that CI catches the Windows failure without relying on commands unavailable on a typical Windows system.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, powershell, rust
- Domain
- build-system, ci-cd, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100