tursodatabase / tursodatabase/libsql-js

Improve error message for "Sync not yet implemented"

Open
#174 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
335
Forks
48
Avg merge
3d 2h
Merged PRs (30d)
3

Description

When attempting to use offline writes with sqld, the following error is returned:

Syncing database ...
thread '<unnamed>' panicked at src/errors.rs:22:13:
not yet implemented: err = Sync(PullFrame(404, ""))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[1]    47439 abort      node index.mjs

You can somewhat decipher with the "not yet implemented" error that this isn't using a version of turso-server, because we know it's implemented but it wasn't immediately clear. We can do provide a better message here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing offline writes with sqld, then inspect src/errors.rs around line 22 where the panic is reported. Compare the current error with the shown Sync(PullFrame(404, "")) output and determine what diagnostic should make the server/version mismatch understandable. Done means the same failure produces a clearer message.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.