tscircuit / tscircuit/props

fuseProps accepts any string as a connections key, unlike every other component

Open Beginner friendly
#754 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
6
Forks
59
Avg merge
2h 30m
Merged PRs (30d)
34

Description

Summary

fuseProps accepts any string as a connections key. A typo'd pin name — or a key that isn't a pin at all — passes validation silently, where every other component rejects it.

const typo = { pin99: ".R1 > .pin1" }

fuseProps.safeParse({ name: "F1", currentRating: "1A", connections: typo })
// → success: true   ❌

capacitorProps.safeParse({ name: "C1", capacitance: "1uF", connections: typo })
// → success: false  ✅
resistorProps.safeParse({ name: "R1", resistance: "1k", connections: typo })
// → success: false  ✅

A fuse is a two-pin passive exactly like a resistor or capacitor, so there's no reason for it to behave differently here.

Everything gets through:

connections result
{ pin1: "..." } accepted (correct)
{ pin99: "..." } accepted
{ "not a pin at all": "..." } accepted
{ "": "..." } accepted

The empty-key case is worth calling out: "" isn't a selector, and downstream that produces an internal CSS-parser error rather than anything actionable (I filed that side of it as tscircuit/core#2865).

Cause

Two related gaps in lib/components/fuse.ts.

1. It hand-rolls the connections schema instead of using the shared helper. Every other component builds it from its own pin labels:

// capacitor.ts, resistor.ts, ...
connections: createConnectionsProp(capacitorPinLabels).optional(),

createConnectionsProp keys the record on z.enum(labels), so unknown keys fail. Fuse instead does:

// fuse.ts
connections: z
  .record(z.string(), z.union([...]))    // ← any key passes
  .optional(),

The file already defines fusePinLabels = ["pin1", "pin2"] and exports it — it just isn't used for this.

2. Nothing checks the schema against the interface. FuseProps declares connections?: Connections<PinLabel> while the schema produces Record<string, ...>. That mismatch is exactly what expectTypesMatch exists to catch, and fuse is the only component in lib/components/ that exports both an interface and an Inferred* type without calling it. (I checked all 20 files that omit expectTypesMatch; the rest don't export both, so fuse is the single gap.)

Adding the check to the current file proves the drift:

error TS2345: Argument of type 'true' is not assignable to parameter of
type '"property connections has mismatched types"'.

So the invariant the repo relies on was never applied here, and the types silently diverged.

Expected

fuseProps should build connections from fusePinLabels like every other component, and the file should carry the expectTypesMatch assertion so this can't drift again.

PR follows.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/components/fuse.ts and compare its connections schema with the shared createConnectionsProp usage in capacitor.ts or resistor.ts. Review fusePinLabels and the expectTypesMatch pattern, then confirm that unknown connection keys are rejected and the interface and inferred schema types match.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
83/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.