inductor: unit strings violate the Circuit JSON inductance type
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 58
- Forks
- 203
- Avg merge
- 7h 39m
- Merged PRs (30d)
- 286
Description
A documented string value such as inductance="10uH" is emitted as a string even though SourceSimpleInductor.inductance requires numeric henries.
Expected: parse the unit string to a numeric henry value, or reject it.
Actual: a string reaches Circuit JSON.
Standalone repro: https://github.com/0hmX/tscircuit-repro-inductor-string-inductance
Core repro PR: not yet created.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the standalone inductor repro and inspect the core path that produces Circuit JSON for SourceSimpleInductor.inductance. The work is done when the documented "10uH" input is either converted to numeric henries or rejected before a string reaches Circuit JSON.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100