resistor: tolerance is omitted from Circuit JSON

Open
#3,103 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript

Research direction

Start with the handling that accepts tolerance and compare it with the emitted Circuit JSON. Use the standalone reproduction and core repro PR to observe the current output. Done means tolerance is preserved in the source/Circuit JSON representation, or the input is rejected consistently.

Written by the indexing model from the issue text.

Description

tolerance is accepted for <resistor /> but is omitted from emitted Circuit JSON.

Expected: preserve the accepted tolerance value in the source/Circuit JSON representation, or reject it consistently.
Actual: only resistance is emitted.

Evidence:

Dominant language
TypeScript
Stars
58
Forks
203
Avg merge
7h 39m
Merged PRs (30d)
286

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tscircuit/core

All issues in tscircuit/core

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.