tryAGI / tryAGI/LangChain.Databases
implement maximal_marginal_relevance method or call python?
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 12
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
var embeddingArray = embedding.ToArray();
var results = await _postgresDbClient
.GetWithDistanceAsync(
_collectionName,
embeddingArray,
_distanceStrategy,
limit: k,
withEmbeddings: true,
cancellationToken: cancellationToken)
.ConfigureAwait(false);
var mmrSelected = maximal_marginal_relevance(
embeddingArray,
results.Select(r => r.Item1.Embedding!),
k: k,
lambdaMult: lambdaMult);
var resultDocs = results
.Select((r, i) => (Record: r.Item1, Index: i))
.Where(v => mmrSelected.Contains(v.Index))
.Select(v => new Document(v.Record.Content, v.Record.Metadata));
return resultDocs;
namespace LangChain.Databases.Postgres;
/// <summary>
/// Postgres vector store (using <see href="https://github.com/pgvector/pgvector"/>)
/// <remarks>
/// required: CREATE EXTENSION IF NOT EXISTS vector
/// </remarks>
/// </summary>
public class PostgresVectorCollection(
PostgresDbClient client,
string name = VectorCollection.DefaultName,
string? id = null)
: VectorCollection(name, id), IVectorCollection
{
/// <inheritdoc />
public async Task<IReadOnlyCollection<string>> AddAsync(
IReadOnlyCollection<Vector> items,
CancellationToken cancellationToken = default)
{
items = items ?? throw new ArgumentNullException(nameof(items));
foreach (var item in items)
{
await client.UpsertAsync(
tableName: Name,
id: item.Id,
content: item.Text,
metadata: item.Metadata,
embedding: item.Embedding,
timestamp: DateTime.UtcNow,
cancellationToken: cancellationToken
).ConfigureAwait(false);
}
return items
.Select(i => i.Id)
.ToArray();
}
/// <inheritdoc />
public async Task<Vector?> GetAsync(string id, CancellationToken cancellationToken = default)
{
var record = await client.GetRecordByIdAsync(Name, id, withEmbeddings: false, cancellationToken).ConfigureAwait(false);
return record != null
? new Vector
{
Text = record.Content,
Metadata = record.Metadata,
}
: null;
}
/// <inheritdoc />
public async Task<bool> DeleteAsync(IEnumerable<string> ids, CancellationToken cancellationToken = default)
{
await client
.DeleteBatchAsync(Name, ids.ToList(), cancellationToken)
.ConfigureAwait(false);
return true;
}
/// <inheritdoc />
public async Task<VectorSearchResponse> SearchAsync(
VectorSearchRequest request,
VectorSearchSettings? settings = default,
CancellationToken cancellationToken = default)
{
request = request ?? throw new ArgumentNullException(nameof(request));
settings ??= new VectorSearchSettings();
var records = await client
.GetWithDistanceAsync(
Name,
request.Embeddings.First(),
settings.DistanceStrategy,
limit: settings.NumberOfResults,
cancellationToken: cancellationToken)
.ConfigureAwait(false);
// MMR
// TODO: implement maximal_marginal_relevance method or call python?
// var embeddingArray = embedding.ToArray();
// var results = await _postgresDbClient
// .GetWithDistanceAsync(
// _collectionName,
// embeddingArray,
// _distanceStrategy,
// limit: k,
// withEmbeddings: true,
// cancellationToken: cancellationToken)
// .ConfigureAwait(false);
//
// var mmrSelected = maximal_marginal_relevance(
// embeddingArray,
// results.Select(r => r.Item1.Embedding!),
// k: k,
// lambdaMult: lambdaMult);
//
// var resultDocs = results
// .Select((r, i) => (Record: r.Item1, Index: i))
// .Where(v => mmrSelected.Contains(v.Index))
// .Select(v => new Document(v.Record.Content, v.Record.Metadata));
//
// return resultDocs;
return new VectorSearchResponse
{
Items = records
.Select(r => new Vector
{
Text = r.Item1.Content,
Metadata = r.Item1.Metadata,
Distance = r.Item2,
})
.ToArray(),
};
}
/// <inheritdoc />
public Task<bool> IsEmptyAsync(CancellationToken cancellationToken = default)
{
throw new NotImplementedException();
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Postgres/src/PostgresVectorCollection.cs at SearchAsync and its MMR TODO, then review the existing GetWithDistanceAsync result shape and vector-search settings. Decide how maximal marginal relevance should be provided in this C# PostgreSQL implementation; done means SearchAsync applies the selected MMR behavior and returns the expected VectorSearchResponse.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, postgresql
- Domain
- databases, machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100