trustedsec / trustedsec/hate_crack

[BUG] Hashview HTTPS verification bypasses TLS

Open
#329 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
1.9k
Forks
284
Avg merge
21m
Merged PRs (30d)
14

Description

Problem

The HashviewAPI class disables SSL/TLS certificate verification when making HTTP requests:

# hate_crack/api.py (around line 1584)
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
self.session.verify = False

This means man-in-the-middle attacks against the Hashview connection are silently accepted, and there is no way for operators to enable proper TLS validation.

Location

  • File: hate_crack/api.py
  • Lines: ~1257, ~1515 (HashviewAPI.init), ~1584 (urllib3.disable_warnings)
  • Class: HashviewAPI

Impact

  • Allows attackers to intercept API credentials and responses
  • The session.verify = False makes all requests vulnerable to MITM

Recommendation

If Hashview is accessed externally, TLS verification should be enforced. If this is only for local/docker usage, should be:

  1. Documented in code comments
  2. Made opt-in via config/env flag
  3. Or use --insecure-style flags with clear warnings upon disabling

Related

This mirrors the pattern where HashcatRosetta submodule import errors are preserved (not silently discarded), consistency in error handling is preferred.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in hate_crack/api.py at HashviewAPI.init and the request setup around lines 1257, 1515, and 1584. Trace how Hashview connections are configured, then ensure certificate verification is enforced by default and that any insecure option is explicit and clearly warned about; the existing Hashview behavior should no longer silently accept MITM connections.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.