tronprotocol / tronprotocol/tronweb
**[blocker]** The supplied `payload.primaryType` does not affect this signature or the digest: both calls receive only `domain`, the complete `types` map, and `message`; `primaryType` is merely echoed on line 35. With a payload that explicitly selects a declared type other than TronWeb’s inferred root, the command can therefore sign one type while reporting another. Please derive the type set rooted at the selected `primaryType` (or reject an incompatible selection) and use that same selection for signing
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 569
- Forks
- 385
- Avg merge
- 56m
- Merged PRs (30d)
- 2
Description
[blocker] The supplied payload.primaryType does not affect this signature or the digest: both calls receive only domain, the complete types map, and message; primaryType is merely echoed on line 35. With a payload that explicitly selects a declared type other than TronWeb’s inferred root, the command can therefore sign one type while reporting another. Please derive the type set rooted at the selected primaryType (or reject an incompatible selection) and use that same selection for signing, digesting, and reporting.
Originally posted by @matrix-agent116 in https://github.com/tronprotocol/wallet-cli/pull/957#discussion_r3642830827
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the command implementation and the two signing or digest calls described in the issue, including the line where primaryType is echoed. Compare TronWeb’s inferred root with an explicitly selected declared type. Done means signing, digesting, and reporting consistently use the selected compatible root, or reject an incompatible selection, with focused tests for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli, cryptography
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100