10% of tests in scripts/Tests don't contain an assertion
Open
@catb0t is already working on this.
Since Nov 11, 2018.
unit-tests
- Dominant language
- Perl
- Stars
- 126
- Forks
- 2
- Avg merge
- 15m
- Merged PRs (30d)
- 3
Description
There are 11,000 lines of testing code in scripts/Tests (more than Ruby's parser in C) and I'm not looking to re-write it all right now, but 136 of those 1400 files don't assert anything.
It's not horrible but it does mean that hacking on Sidef could silently break some printed output, that just whizzes by in the whole test output, which is what TDD should prevent.
(the alpha-stage Luciu was designed with this in mind, so a Luciu test case without a call to skip() or the rest of Luciu, is considered Failed+Empty, which causes the enclosing file to be considered Failed too.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.