trixi-framework / trixi-framework/TrixiParticles.jl
IISPH is not correctly considering velocity of moving boundaries
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 83
- Forks
- 24
- Avg merge
- 8d 18h
- Merged PRs (30d)
- 3
Description
With #751, the predicted velocity of boundary particles is defined as zero:
@propagate_inbounds function predicted_velocity(system::BoundarySystem, particle)
return zero(SVector{ndims(system), eltype(system)})
end
For moving boundaries, this should instead be the prescribed velocity at the next time step.
There might be other instances where the equations have to be changed to correctly support moving boundaries.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the predicted_velocity(system::BoundarySystem, particle) definition shown in the issue and review the changes from #751. Trace how predicted boundary velocities are used in the moving-boundary equations, identify any other affected instances, and verify that prescribed velocity is applied at the next time step.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100