trixi-framework / trixi-framework/TrixiParticles.jl
TLSPH doesn't work across periodic boundaries
Open
Nobody has claimed this yet.
bug
- Dominant language
- Julia
- Stars
- 83
- Forks
- 24
- Avg merge
- 8d 18h
- Merged PRs (30d)
- 3
Description
This has to use the periodic distance. For this, we first have to add public API to PointNeighbors.jl for this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/schemes/solid/total_lagrangian_sph/system.jl around line 299 and inspect how the distance is computed. Then investigate the required public API in PointNeighbors.jl for periodic distance handling. Done means TLSPH works correctly across periodic boundaries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100