trixi-framework / trixi-framework/TrixiParticles.jl

Color is always set for boundary systems

Open
#747 2 comments 0 reactions 1 assignee View on GitHub

@svchb is already working on this.

Since Apr 3, 2025.

Dominant language
Julia
Stars
83
Forks
24
Avg merge
8d 18h
Merged PRs (30d)
3

Description

https://github.com/trixi-framework/TrixiParticles.jl/blob/aa110a6f89a3f7cb930d5ac09498c56fba6013a9/src/schemes/boundary/system.jl#L47

@svchb It seems we missed that in the reviews. The color value is always set in the boundary cache, which defeats the purpose of the cache to hold values that only exist in certain circumstances.
Can you please fix that?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.