trixi-framework / trixi-framework/TrixiParticles.jl

Function in interpolation is untested

Open
#744 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug testing
Dominant language
Julia
Stars
83
Forks
24
Avg merge
8d 18h
Merged PRs (30d)
3

Description

https://github.com/trixi-framework/TrixiParticles.jl/blob/9d62c33b247545f2400469a347a95f81925373e2/src/general/interpolation.jl#L622-L642
This function is clearly untested and wouldn't work, as interpolation_values doesn't even exist.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/general/interpolation.jl at lines 622-642 and trace the surrounding interpolation code to determine the intended inputs and outputs. Run the existing test suite to identify relevant interpolation tests, then add coverage for this function and ensure it no longer references the nonexistent interpolation_values variable.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.