trixi-framework / trixi-framework/TrixiParticles.jl
Initialization of optional values depending on other system models
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 83
- Forks
- 24
- Avg merge
- 8d 18h
- Merged PRs (30d)
- 3
Description
As in #539 and other PRs it is a problem to initialise other systems based on the model selection:
I suggest adding in semidiscretization:
for_each(semi) do system_A
for_each(semi) do system_B
# pseudocode
if system_A == system_B continue end
initialize!(system_A, system_B)
end
end
And handling all initialization that is based on other systems in the dispatch of initialize!(system_A, system_B).
Examples of this are:
- Initialization concerning surface normals and surface tension
- Corrections
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the semidiscretization logic and the initialize!(system_A, system_B) dispatch described in the issue. Determine how dependent initialization should cover surface normals, surface tension, and corrections, then verify that initialization works for every pair of distinct systems.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100