trixi-framework / trixi-framework/TrixiParticles.jl

The surface normal methods smoothing length and kernel should be able to be set separately

Open
#668 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
83
Forks
24
Avg merge
8d 18h
Merged PRs (30d)
3

Description

Papers usually recommend using a higher smoothing_length or smoother kernel with surface normal methods.
Currently this can be only done using this quite inefficient approach:

    if smoothing_length != system.smoothing_length ||
       smoothing_kernel !== system.smoothing_kernel
        # TODO: this is really slow but there is no way to easily implement multiple search radia
        search_radius = compact_support(smoothing_kernel, smoothing_length)
        nhs = PointNeighbors.copy_neighborhood_search(nhs, search_radius,
                                                      nparticles(system))
        PointNeighbors.initialize!(nhs, system_coords, neighbor_system_coords)
    end

This was removed from #539 #584 and #666

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the surface normal methods and reviewing the removed approaches referenced in #539, #584, and #666. Determine how neighbor search radii could support independent smoothing_length and smoothing_kernel settings without the inefficient neighborhood copy; done means those settings work separately with appropriate surface normals.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.