trixi-framework / trixi-framework/TrixiParticles.jl

Running dam_break with Monaghan-Kajtar yields incorrect results

Open
#598 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Julia
Stars
83
Forks
24
Avg merge
8d 18h
Merged PRs (30d)
3

Description

setting our previous values:
boundary_layers=1
spacing_ratio=3
boundary_model = BoundaryModelMonaghanKajtar(1.0/(gravity), 3.0, boundary_particle_spacing, tank.boundary.mass)

yields
image (5)
image (4)

It might just be caused by needing a relaxation step?
Anyway I did not investigate further.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the dam_break case with boundary_layers=1, spacing_ratio=3, and BoundaryModelMonaghanKajtar using the values shown in the issue. Compare the resulting behavior with the attached images and investigate whether a relaxation step is required; done means identifying the cause and confirming corrected results.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.