trixi-framework / trixi-framework/TrixiParticles.jl
Fix wrong arrays passed to interpolation
Open
Nobody has claimed this yet.
bug
- Dominant language
- Julia
- Stars
- 83
- Forks
- 24
- Avg merge
- 8d 18h
- Merged PRs (30d)
- 3
Description
In #462 and the dam break validation, v and u are passed to the interpolation instead of v_ode and u_ode. This is not correct, and it only works when the system is the first one in the semidiscretization.
We need to fix this once #424 is resolved.
I thought I already created an issue for this, but I can't find it now.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First check issue #424 and the interpolation call sites referenced in #462 and the dam break validation. Confirm where v, u, v_ode, and u_ode are selected; done means interpolation receives v_ode and u_ode and the validation no longer depends on the system being first.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100