trixi-framework / trixi-framework/TrixiParticles.jl

Handling mandatory callbacks for specific methods

Open
#494 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion
Dominant language
Julia
Stars
83
Forks
24
Avg merge
8d 18h
Merged PRs (30d)
3

Description

For some methods such as TVF and OpenBC an update each full time step is necessary. That makes the update callback in #440 mandatory for a simulation.

We can't just check , e.g. in the Semidiscretization, whether the update callback is in the callbackset or not since the callbackset is directly passed to solve.

@efaulhaber @svchb any thoughts on that?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the update callback from issue #440 and tracing how Semidiscretization passes the callbackset to solve for TVF and OpenBC simulations. Determine how a mandatory callback should be represented and validated, then define tests showing that required updates are enforced without affecting optional callbacks.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.